chore(tooling): update kcd-scripts #600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
previously approved these changes
Oct 11, 2018
Member
kentcdodds
left a comment
kentcdodds
left a comment
There was a problem hiding this comment.
Cool! Could you verify for me that the umd bundle has the @babel/runtime dep bundled?
Collaborator
Author
|
UMD function _objectWithoutPropertiesLoose(source, excluded) {
// ...
}
function _extends() {
// ..
}ESM import computeScrollIntoView from 'compute-scroll-into-view';
import _objectWithoutPropertiesLoose from '@babel/runtime/helpers/esm/objectWithoutPropertiesLoose';
import _extends from '@babel/runtime/helpers/esm/extends';
import _inheritsLoose from '@babel/runtime/helpers/esm/inheritsLoose';
import _assertThisInitialized from '@babel/runtime/helpers/esm/assertThisInitialized';
import React, { Component } from 'react';
import PropTypes from 'prop-types'; |
Collaborator
Author
|
Tests are wrongly configured though (might be because of kcd-scripts upgrade) - gonna take a look soon & ping you once I fix it. |
Member
|
Thanks! |
Andarist
force-pushed
the
update-kcd-scripts
branch
from
ffabe2e to
407c0f5
Compare
Codecov Report
@@ Coverage Diff @@
## master #600 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 366 366
Branches 92 92
=====================================
Hits 366 366Continue to review full report at Codecov.
|
Collaborator
Author
Member
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
kentcdodds/kcd-scripts#71